-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/week6 2 #10
Feature/week6 2 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
etPassword.backgroundTintList = | ||
ColorStateList.valueOf(getColor(R.color.black)) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
덕분에 ColorStateList에 대해 알게 되었습니당~! 저도 공부해봐야겠어요ㅎㅎ
@@ -19,10 +22,7 @@ | |||
android:exported="true" | |||
android:windowSoftInputMode="adjustPan"></activity> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소한 거지만 > 대신 />로 닫아도 될 것 같네요 !
changeFragment(GalleryFragment()) | ||
return@setOnItemSelectedListener true | ||
} | ||
R.id.menu_profile -> { | ||
changeFragment(MyProfileFragment()) | ||
return@setOnItemSelectedListener true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요렇게 로직을 구현할 경우 Fragment 객체를 매번 생성해야 할 것 같아요!
이를 한 번만 생성하여 사용할 수도 있을까요 !?
with(binding) { | ||
etId.clearFocus() | ||
etPassword.clearFocus() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 요 부분은 키보드를 내릴 뿐 아니라 EditText의 포커싱도 지워주는 것일까요 !?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 네네 맞습니다!!
intent.putExtra("name", MySharedPreferences.getUserName(this)) | ||
intent.putExtra("speciality", MySharedPreferences.getUserSpec(this)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 요건 SharedPreferences에 등록했으니 다음 액티비티에서 SharedPreferences에 접근해서 값을 가져와도 될 것 같은데, 요렇게 Intent를 통한 전달을 해주신 이유가 있을까요 !?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오... 생각해보니 그렇네요
로그인한 데이터를 이용해 profile 정보를 띄워야지! >> 데이터를 넘겨야지! 하면서 그렇게 만든거 같은데, 지금 생각해보면 비효율적이네요..
private fun signUp() { | ||
canClickButton() | ||
binding.btnSignup.setOnClickListener { | ||
if (binding.etId.text.length in 6..10 && binding.etPassword.text.length in 8..12) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 if 내의 조건을 isIdPwValid 등의 함수로 뺀다면 더욱 가독성이 좋을 것 같아요 !
} | ||
} | ||
|
||
}) | ||
|
||
|
||
} | ||
|
||
} | ||
|
||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 그림그려도 되겠는데요 ㅋㅋㅋㅋㅋㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ,,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 ~~ 고생하셨어요 !
구현사항
KakaoTalk_20230602_221903037.mp4